Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NIT-2607] Change atomic.Store to atomic.Type #2449

Merged
merged 5 commits into from
Jul 15, 2024
Merged

[NIT-2607] Change atomic.Store to atomic.Type #2449

merged 5 commits into from
Jul 15, 2024

Conversation

amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Jul 1, 2024

No description provided.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jul 1, 2024
@amsanghi amsanghi marked this pull request as ready for review July 1, 2024 12:53
@amsanghi amsanghi changed the title Change atomic.Store to atomic.Type [NIT-2607] Change atomic.Store to atomic.Type Jul 1, 2024
@joshuacolvin0 joshuacolvin0 requested review from eljobe and gligneul July 9, 2024 20:28
gligneul
gligneul approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@gligneul gligneul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eljobe
eljobe approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 enabled auto-merge July 15, 2024 20:24
@joshuacolvin0 joshuacolvin0 merged commit c768543 into master Jul 15, 2024
13 checks passed
@joshuacolvin0 joshuacolvin0 deleted the atomic branch July 15, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gligneul gligneul gligneul approved these changes

@eljobe eljobe eljobe approved these changes

Assignees
No one assigned
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amsanghi @eljobe @gligneul @joshuacolvin0