Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Before posting a batch, run it through the inbox multiplexer and confirm it produces the expected set of messages #2371

Merged
merged 14 commits into from
Aug 8, 2024

Conversation

ganeshvanahalli
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli commented Jun 5, 2024

Resolves NIT-2582

…irm it produces the expected set of messages
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jun 5, 2024
@ganeshvanahalli ganeshvanahalli marked this pull request as ready for review June 6, 2024 15:44
Copy link
Member

@Tristan-Wilson Tristan-Wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just one small request for a comment/name change.

arbnode/batch_poster.go Outdated Show resolved Hide resolved
Tristan-Wilson
Tristan-Wilson previously approved these changes Jun 6, 2024
Copy link
Member

@Tristan-Wilson Tristan-Wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 requested a review from gligneul June 12, 2024 01:01
gligneul
gligneul previously approved these changes Jun 13, 2024
magicxyyz
magicxyyz previously approved these changes Jun 18, 2024
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one nitpicking comment

arbnode/batch_poster.go Outdated Show resolved Hide resolved
Tristan-Wilson
Tristan-Wilson previously approved these changes Jul 4, 2024
gligneul
gligneul previously approved these changes Jul 4, 2024
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM but I have a couple small suggestions

arbnode/batch_poster.go Show resolved Hide resolved
arbnode/batch_poster.go Outdated Show resolved Hide resolved
arbnode/batch_poster.go Show resolved Hide resolved
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit f8a0013 into master Aug 8, 2024
13 checks passed
@PlasmaPower PlasmaPower deleted the check-batch-correctness branch August 8, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants