[NIT-2740] Horizontal Scaling of Validation Node #2354
+433
−89
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| package redis | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
|
|
||
| "github.com/ethereum/go-ethereum/common" | ||
| "github.com/ethereum/go-ethereum/log" | ||
| "github.com/offchainlabs/nitro/pubsub" | ||
| "github.com/offchainlabs/nitro/util/containers" | ||
| "github.com/offchainlabs/nitro/util/redisutil" | ||
| "github.com/offchainlabs/nitro/util/stopwaiter" | ||
| "github.com/offchainlabs/nitro/validator/server_api" | ||
| ) | ||
|
|
||
| // BoldValidationClient implements bold validation client through redis streams. | ||
| type BoldValidationClient struct { | ||
| stopwaiter.StopWaiter | ||
| // producers stores moduleRoot to producer mapping. | ||
| producers map[common.Hash]*pubsub.Producer[*server_api.GetLeavesWithStepSizeInput, []common.Hash] | ||
| config *ValidationClientConfig | ||
| } | ||
|
|
||
| func NewBoldValidationClient(cfg *ValidationClientConfig) (*BoldValidationClient, error) { | ||
| return &BoldValidationClient{ | ||
| producers: make(map[common.Hash]*pubsub.Producer[*server_api.GetLeavesWithStepSizeInput, []common.Hash]), | ||
| config: cfg, | ||
| }, nil | ||
| } | ||
|
|
||
| func (c *BoldValidationClient) Initialize(ctx context.Context, moduleRoots []common.Hash) error { | ||
| if c.config.RedisURL == "" { | ||
| return fmt.Errorf("redis url cannot be empty") | ||
| } | ||
| redisClient, err := redisutil.RedisClientFromURL(c.config.RedisURL) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| for _, mr := range moduleRoots { | ||
| if c.config.CreateStreams { | ||
| if err := pubsub.CreateStream(ctx, server_api.RedisBoldStreamForRoot(c.config.StreamPrefix, mr), redisClient); err != nil { | ||
| return fmt.Errorf("creating redis stream: %w", err) | ||
| } | ||
| } | ||
| if _, exists := c.producers[mr]; exists { | ||
| log.Warn("Producer already existsw for module root", "hash", mr) | ||
rauljordan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| continue | ||
| } | ||
| p, err := pubsub.NewProducer[*server_api.GetLeavesWithStepSizeInput, []common.Hash]( | ||
| redisClient, server_api.RedisBoldStreamForRoot(c.config.StreamPrefix, mr), &c.config.ProducerConfig) | ||
| if err != nil { | ||
| log.Warn("failed init redis for %v: %w", mr, err) | ||
| continue | ||
| } | ||
| p.Start(c.GetContext()) | ||
| c.producers[mr] = p | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (c *BoldValidationClient) GetLeavesWithStepSize(req *server_api.GetLeavesWithStepSizeInput) containers.PromiseInterface[[]common.Hash] { | ||
| producer, found := c.producers[req.ModuleRoot] | ||
| if !found { | ||
| return containers.NewReadyPromise([]common.Hash{}, fmt.Errorf("no validation is configured for wasm root %v", req.ModuleRoot)) | ||
| } | ||
| promise, err := producer.Produce(c.GetContext(), req) | ||
| if err != nil { | ||
| return containers.NewReadyPromise([]common.Hash{}, fmt.Errorf("error producing input: %w", err)) | ||
| } | ||
| return promise | ||
| } | ||
|
|
||
| func (c *BoldValidationClient) Start(ctx_in context.Context) error { | ||
| for _, p := range c.producers { | ||
| p.Start(ctx_in) | ||
| } | ||
| c.StopWaiter.Start(ctx_in, c) | ||
| return nil | ||
| } | ||
|
|
||
| func (c *BoldValidationClient) Stop() { | ||
| for _, p := range c.producers { | ||
| p.StopAndWait() | ||
| } | ||
| c.StopWaiter.StopAndWait() | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need a separate one for BOLD or could we use the same one?