Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changes from geth's SendTxArg to Nitro's SignTxArgs #2348

Closed
wants to merge 4 commits into from

Conversation

anodar
Copy link
Contributor

@anodar anodar commented May 29, 2024

No description provided.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label May 29, 2024
@anodar anodar requested a review from PlasmaPower May 29, 2024 13:09
@anodar anodar marked this pull request as ready for review May 29, 2024 13:55
@anodar anodar requested review from Tristan-Wilson and amsanghi June 3, 2024 16:04
Copy link
Member

@Tristan-Wilson Tristan-Wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anodar
Copy link
Contributor Author

anodar commented Jun 11, 2024

As per Lee's request (since we can't copy-paste code from geth into nitro because of licenses), closing this and cherry-picking changes into our geth fork instead: OffchainLabs/go-ethereum#327, #2379.

@anodar anodar closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants