Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylus cache tag #2315

Merged
merged 8 commits into from
May 21, 2024
Merged

Stylus cache tag #2315

merged 8 commits into from
May 21, 2024

Conversation

tsahee
Copy link
Contributor

@tsahee tsahee commented May 17, 2024

Pulls in OffchainLabs/go-ethereum#319

Stylus-cache tag is added to ethdb and state.Database. Currently tag==1 means local compiled wasm will be cached with wasm-cache, and any other tag means it won't be (tag==0 will always mean using LRU cache only)

This:

  • allows running tests in parallel without interefering with one another
  • allows recording-db not to interfere with normal arbos
  • by checking runmode in CallProgram: makes sure eth_calls etc will not affect arbos cache

In addition, a config option to change LRU-cache size is added

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label May 17, 2024
@tsahee tsahee force-pushed the stylus_cache_tag branch from 368847b to cd03bf0 Compare May 17, 2024 22:37
@joshuacolvin0 joshuacolvin0 requested a review from magicxyyz May 17, 2024 23:35
@tsahee tsahee requested a review from PlasmaPower May 18, 2024 00:05
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 109b284 into master May 21, 2024
11 checks passed
@PlasmaPower PlasmaPower deleted the stylus_cache_tag branch May 21, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants