Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signed saturating math functions #2306

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

PlasmaPower
Copy link
Collaborator

In addition to the test cases, I ran each of the fuzzers for 2 minutes:

for f in FuzzSaturatingAddInt8 FuzzSaturatingAddInt16 FuzzSaturatingAddInt32 FuzzSaturatingAddInt64 FuzzSaturatingSub FuzzSaturatingMulInt8 FuzzSaturatingMulInt16 FuzzSaturatingMulInt32 FuzzSaturatingMulInt64 FuzzSaturatingNegInt8 FuzzSaturatingNegInt16 FuzzSaturatingNegInt32 FuzzSaturatingNegInt64; do go test ./util/arbmath -fuzz "$f" -fuzztime 2m || break; done

I'll run them for longer overnight to make sure but I'm pretty confident in it given this testing.

@PlasmaPower PlasmaPower requested a review from tsahee May 16, 2024 04:48
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label May 16, 2024
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower enabled auto-merge May 16, 2024 15:57
@PlasmaPower PlasmaPower merged commit 51b12a6 into master May 16, 2024
10 checks passed
@PlasmaPower PlasmaPower deleted the saturating-math-fixes branch May 16, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants