Implement tracing and CPU profiling of long running block creations [NIT-2501] #2305
Conversation
cla-bot
bot
added
the
s
anodar
changed the title
execution/gethexec/sequencer.go
Outdated
| pprof.StopCPUProfile() | ||
| trace.Stop() | ||
| closeFiles(pprofFile, traceFile) | ||
| if elapsed > 5*time.Second { |
There was a problem hiding this comment.
does it make sense to make the time threshold configurable?
There was a problem hiding this comment.
I have similar argument here as above, this is just for debugging why do some queries take long time. (Just like in existing code:
nitro/execution/gethexec/sequencer.go
Line 898 in 3cc94a3
My reasoning in this case for not having configurable is that I believe we already have too many flags, majority of which never actually varies. I'm hesitant to add another one like that, unless we have a good reason.
In any case, if you see more value in that, happy to make it configurable.
There was a problem hiding this comment.
Makes sense, but I wander if 5 seconds for block creation isn't too high threshold.
There was a problem hiding this comment.
Discussed with Lee, he suggested 2 seconds and I've changed to that.
execution/gethexec/sequencer.go
Outdated
| pprof.StopCPUProfile() | ||
| trace.Stop() | ||
| closeFiles(pprofFile, traceFile) | ||
| if elapsed > 5*time.Second { |
There was a problem hiding this comment.
Makes sense, but I wander if 5 seconds for block creation isn't too high threshold.
No description provided.