[Config Change] Multi exec servers #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
returns all the wasmModuleRoots that the application supports
Multiple rpc-URLs are just for multiple execution client. Every validation is only run on one validation client per wasmModuleRoot. Fa
cla-bot
bot
added
the
s
|
Testing with multiple exec servers done in this draft PR: #2268 |
PlasmaPower
requested changes
May 1, 2024
| supported, err := spawner.WasmModuleRoots() | ||
| if err != nil { | ||
| log.Warn("WasmModuleRoots returned error", "err", err) | ||
| return false |
There was a problem hiding this comment.
This case is a bit concerning to me because we'll somewhat silently permanently disable this validator. Shouldn't we return an error here?
There was a problem hiding this comment.
I changed scemantics to only require one validation to succeed per wasmModuleRoot. So if one spawner is down for some reason but others can cover for it - it'll work which seems like the right behavior to me. If no spawner is found for a certain root it will error out in a different pace.
PlasmaPower
reviewed
May 1, 2024
| RUN apt-get install -y xxd | ||
| RUN export DEBIAN_FRONTEND=noninteractive && \ | ||
| apt-get update && \ | ||
| apt-get install -y xxd netcat-traditional |
There was a problem hiding this comment.
I think we should remove the apt cache after this
| @@ -398,7 +398,7 @@ func (v *StatelessBlockValidator) ValidateResult( | |||
| } | |||
| } | |||
| if run == nil { | |||
| return false, &entry.End, errors.New("this validation not supported by node") | |||
| return false, nil, fmt.Errorf("validation woth WasmModuleRoot %v not supported by node", moduleRoot) | |||
PlasmaPower
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes rpc validation-only clients.
Rpc clients will always be execution clients.
Both validation and exec clients can support a list of wasmModuleRoots.
Validations are executed against one client only (per wasmModuleRoot), wich will either be a redis queue or if not found an execution server.
This PR also creates a Docker with split-validation, which only has one validator but will be used as base for multi-validator dockers