Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve blocks re-execution and make it compatible with --init.then-quit #2222

Merged
merged 9 commits into from
May 23, 2024
Merged

Improve blocks re-execution and make it compatible with --init.then-quit #2222

merged 9 commits into from
May 23, 2024

Conversation

ganeshvanahalli
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli commented Apr 8, 2024 •
edited
Loading

Resolves NIT-2399
Resolves NIT-2480

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Apr 8, 2024
@ganeshvanahalli ganeshvanahalli marked this pull request as ready for review April 8, 2024 22:05
@joshuacolvin0 joshuacolvin0 requested a review from magicxyyz April 30, 2024 00:09
magicxyyz
magicxyyz requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just few comments to address

blocks_reexecutor/blocks_reexecutor.go Outdated Show resolved Hide resolved
blocks_reexecutor/blocks_reexecutor.go Show resolved Hide resolved
blocks_reexecutor/blocks_reexecutor.go Show resolved Hide resolved
blocks_reexecutor/blocks_reexecutor.go Outdated Show resolved Hide resolved
@ganeshvanahalli ganeshvanahalli requested a review from magicxyyz May 17, 2024 18:26
magicxyyz
magicxyyz requested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, one small change needed

blocks_reexecutor/blocks_reexecutor.go Outdated Show resolved Hide resolved
blocks_reexecutor/blocks_reexecutor.go Outdated Show resolved Hide resolved
magicxyyz
magicxyyz approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ganeshvanahalli ganeshvanahalli merged commit ed3f9e0 into master May 23, 2024
10 checks passed
@ganeshvanahalli ganeshvanahalli deleted the improve-blocks-reexecutor branch May 23, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicxyyz magicxyyz magicxyyz approved these changes

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganeshvanahalli @magicxyyz