Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't wait on the prefetcher to complete before producing the next block #2216

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

PlasmaPower
Copy link
Collaborator

In this scheme we'll move on to the next block regardless, even if we're executing the next parts of the block in parallel. Hopefully that prefetching is still useful. Even if not, we have plenty of parallelism to spare, the bottlenecks are sequential execution not parallel throughput.

@PlasmaPower PlasmaPower requested review from tsahee and amsanghi April 1, 2024 20:29
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Apr 1, 2024
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit c84507b into master Apr 1, 2024
8 checks passed
@PlasmaPower PlasmaPower deleted the dont-wait-on-prefetcher branch April 1, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants