Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly support replace by fee for blob txs #2164

Merged
merged 12 commits into from
Mar 1, 2024
Merged

Conversation

PlasmaPower
Copy link
Collaborator

No description provided.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Feb 28, 2024
@PlasmaPower PlasmaPower changed the title Properly support replace by fee for blob transactions in the data poster Properly support replace by fee for blob txs Feb 28, 2024
@PlasmaPower PlasmaPower marked this pull request as ready for review February 29, 2024 06:41
Copy link

Copy link
Member

@Tristan-Wilson Tristan-Wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one question.

arbnode/dataposter/data_poster.go Outdated Show resolved Hide resolved
arbnode/dataposter/data_poster.go Show resolved Hide resolved
@@ -452,7 +491,7 @@ func (p *DataPoster) evalMaxFeeCapExpr(backlogOfBatches uint64, elapsed time.Dur
var big4 = big.NewInt(4)

// The dataPosterBacklog argument should *not* include extraBacklog (it's added in in this function)
func (p *DataPoster) feeAndTipCaps(ctx context.Context, nonce uint64, gasLimit uint64, numBlobs int, lastFeeCap *big.Int, lastTipCap *big.Int, dataCreatedAt time.Time, dataPosterBacklog uint64) (*big.Int, *big.Int, *big.Int, error) {
func (p *DataPoster) feeAndTipCaps(ctx context.Context, nonce uint64, gasLimit uint64, numBlobs uint64, lastTx *types.Transaction, dataCreatedAt time.Time, dataPosterBacklog uint64) (*big.Int, *big.Int, *big.Int, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for right now, but this function seems like it could be refactored just a bit to be able to add unit tests for it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a great idea

@PlasmaPower PlasmaPower enabled auto-merge March 1, 2024 20:44
@PlasmaPower PlasmaPower merged commit f10123b into master Mar 1, 2024
8 checks passed
@PlasmaPower PlasmaPower deleted the data-poster-blob-rbf branch March 1, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants