Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump contracts pin and add test to verify pending block's time and number advance #2127

Merged
merged 5 commits into from
Feb 27, 2024
Merged

Bump contracts pin and add test to verify pending block's time and number advance #2127

merged 5 commits into from
Feb 27, 2024

Conversation

ganeshvanahalli
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Feb 2, 2024
@ganeshvanahalli ganeshvanahalli marked this pull request as ready for review February 2, 2024 23:24
magicxyyz
magicxyyz reviewed Feb 19, 2024
View reviewed changes
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a few comments

system_tests/common_test.go Show resolved Hide resolved
cmd/deploy/deploy.go Show resolved Hide resolved
cmd/deploy/deploy.go Outdated Show resolved Hide resolved
cmd/deploy/deploy.go Show resolved Hide resolved
system_tests/ipc_test.go Show resolved Hide resolved
system_tests/ipc_test.go Show resolved Hide resolved
magicxyyz
magicxyyz previously approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one log line needs updating

cmd/deploy/deploy.go Outdated Show resolved Hide resolved
magicxyyz
magicxyyz approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ganeshvanahalli ganeshvanahalli merged commit 8683407 into master Feb 27, 2024
9 checks passed
@ganeshvanahalli ganeshvanahalli deleted the bump-contracts-pin branch February 27, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicxyyz magicxyyz magicxyyz approved these changes

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganeshvanahalli @magicxyyz