Pack more bits into blobs #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
Tristan-Wilson
approved these changes
Jan 25, 2024
| accBits -= 8 | ||
| } | ||
| } | ||
| if accBits != 0 { |
There was a problem hiding this comment.
nice, this should never happen because 4096 is divisible by 4 and the pattern for accBits is 2, 4, 6, 0, repeat on encoding and 6, 4, 2, 0, repeat on decoding.
There was a problem hiding this comment.
Exactly, though this condition (well the one on encoding) helped track down a bug before where I exited the loop early and left some bits in the accumulator
| } | ||
| if accBits != 0 { | ||
| return nil, fmt.Errorf("somehow ended up with %v spare accBits", accBits) | ||
| } | ||
| } | ||
| var outputData []byte | ||
| err := rlp.Decode(bytes.NewReader(rlpData), &outputData) |
There was a problem hiding this comment.
we already have the 1000 byte buffer so I think it's fine, but do we need to take into account the RLP length prefix of the data in the max bytes encoded per blob?
There was a problem hiding this comment.
Yeah that's a good point, though I think we'll just fit in the 1000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Points into #2095
In addition to utilizing all whole bytes of each blob field element, this PR also utilizes all whole bits of each field element, increasing encoding efficiency by roughly 2.5%.
This PR also includes a test of blob encoding and decoding.