Implement 4844 blob reading in replay binary #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
Tristan-Wilson
requested changes
Jan 23, 2024
arbstate/das_reader.go
Outdated
| @@ -55,6 +58,10 @@ func IsZeroheavyEncodedHeaderByte(header byte) bool { | |||
| return (ZeroheavyMessageHeaderFlag & header) > 0 | |||
| } | |||
|
|
|||
| func IsBlobHashesHeaderByte(header byte) bool { | |||
| return (BlobHashesHeaderFlag & header) > 0 | |||
There was a problem hiding this comment.
Is this right if the flag has more than one 1 bit, like 0x50?
There was a problem hiding this comment.
Good point, this isn't right
There was a problem hiding this comment.
Fixed. Great catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added support for the node's inbox reader in this PR since it was a very small additional change (just creating the blob reader in node.go).