Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4844 inbox reader #2092

Merged
merged 55 commits into from
Jan 28, 2024
Merged

4844 inbox reader #2092

merged 55 commits into from
Jan 28, 2024

Conversation

Tristan-Wilson
Copy link
Member

@Tristan-Wilson Tristan-Wilson commented Jan 23, 2024 •
edited
Loading

This PR adds support for Arbitrum Nitro posting and reading batch data as EIP 4844 blobs.

Tristan-Wilson and others added 11 commits January 18, 2024 12:07
@Tristan-Wilson
Use 4844-only contracts branch
640e3e6
@Tristan-Wilson
Handle MaxTimeVariation contract change
312efbb
@Tristan-Wilson
Handle TimeBounds move to Bridge
b9fa608
@Tristan-Wilson
Placeholder zero addresses in DeploySequencerInbox
659553f
@PlasmaPower
Get non-challenge tests passing
9e39151
@PlasmaPower
Use new SequencerInboxStub to fix challenge tests
5e2dfea
@PlasmaPower
Use real blob data readers in challenge tests
750a15f
@PlasmaPower
Update contracts to latest (unified 4844 reader contract)
3619cd1
@Tristan-Wilson
Merge remote-tracking branch 'origin/geth-1.13' into 4844-inbox-reader
93411d2
@Tristan-Wilson
go mod tidy after merging in geth-1.13 branch
574fb73
@Tristan-Wilson
Port BlobClient from old 4844 branch
fe65429 
This ports BlobClient from the eip-4844-experimental branch, with the
prysm dependency removed (relevant code copied to util/beaconclient)
and the kZGToVersionedHash function copied from geth rather than
modifying our fork to make it public as I had done before, since it is
so simple.

"A little copying is better than a little dependency."
- Rob Pike, Go Proverbs
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jan 23, 2024
PlasmaPower and others added 18 commits January 22, 2024 21:07
@PlasmaPower
Implement 4844 blob reading in replay binary
11e61aa
@PlasmaPower
Add foundry to CI
511480e
@PlasmaPower
Install foundry in docker and fix CI
5377d0f
@PlasmaPower
Fix docker build
6cca704
@PlasmaPower
Add 4844 blob tx support to data poster (rbf is wip)
609b4cf
@PlasmaPower
Add support for 4844 batch posting
d3d0e0f
@PlasmaPower
Use updated contracts
d229f3c
@PlasmaPower
Fix bit checks
eba35e5
@PlasmaPower
Merge branch '4844-consensus' into 4844-batch-posting
c6ff17b
@PlasmaPower
Fix Data field type in estimateGasParams
8639116
@PlasmaPower
Merge pull request #2093 from OffchainLabs/4844-consensus
367dfec 
Implement 4844 blob reading in replay binary
@PlasmaPower
Fix raw estimateGas in batch poster
5cdcde1
@PlasmaPower
Misc refactors while I was tracking down the previous bug
54ee5c3
@PlasmaPower
Add option to force posting 4844 blobs
4925e63
@PlasmaPower
Merge branch 'master' into 4844-inbox-reader
633e967
@PlasmaPower
Use custom beacon request helper
b6b54ef
@PlasmaPower
Merge branch 'beacon-request-helper' into 4844-batch-posting
a750ef9
@Tristan-Wilson
Merge pull request #2098 from OffchainLabs/beacon-request-helper
4d87c88 
Use custom beacon request helper
PlasmaPower and others added 17 commits January 23, 2024 19:31
@PlasmaPower
Merge branch '4844-inbox-reader-fixes' into 4844-batch-posting
d7a80df
@PlasmaPower
Fix arbitrator tests and hopefully CI
b482243
@PlasmaPower
Use KZG preimage support in replay binary
ae7a199
@PlasmaPower
Fix arbitrator handling of non-keccak preimages
3de7b73
@PlasmaPower
Provide blob preimages during validation
e82ac72
@PlasmaPower
Fix arbitrator CI
59a8935
@PlasmaPower
Merge pull request #2099 from OffchainLabs/4844-inbox-reader-fixes
eb7d6f8 
4844 inbox reader fixes
@PlasmaPower
Fix Go test
f646430
@PlasmaPower
Strengthen Uint64String parsing
d2b7c9d
@PlasmaPower
Pack more bits into blobs
277f241
@PlasmaPower
Add separate max batch size for 4844
03b2fe8
@PlasmaPower
Merge branch '4844-inbox-reader' into 4844-batch-posting
b660d9b
@PlasmaPower
Merge pull request #2095 from OffchainLabs/4844-batch-posting
5e87053 
4844 batch posting support
@PlasmaPower
Merge pull request #2101 from OffchainLabs/4844-bit-packing
a931a61 
Pack more bits into blobs
@PlasmaPower
Merge branch '4844-inbox-reader' into 4844-validation
10753a9
@PlasmaPower
Merge pull request #2100 from OffchainLabs/4844-validation
83ac9b0 
Add block validation support to 4844 batches
@Tristan-Wilson
Merge remote-tracking branch 'origin/master' into 4844-inbox-reader
71a0fc0 
Conflicts:
	go-ethereum

Pick latest go-ethereum
@Tristan-Wilson Tristan-Wilson marked this pull request as ready for review January 26, 2024 17:43
PlasmaPower
PlasmaPower previously approved these changes Jan 28, 2024
View reviewed changes
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower enabled auto-merge January 28, 2024 05:43
@PlasmaPower PlasmaPower disabled auto-merge January 28, 2024 05:56
PlasmaPower
PlasmaPower approved these changes Jan 28, 2024
View reviewed changes
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving as I just moved contracts back to the previous pin to fix arbitrator CI. We'll eventually want to integrate the latest contracts changes in develop, such as the batch poster manager, but that's a separate change.

@PlasmaPower PlasmaPower enabled auto-merge January 28, 2024 06:08
@PlasmaPower PlasmaPower merged commit 26eb57d into master Jan 28, 2024
9 checks passed
@PlasmaPower PlasmaPower deleted the 4844-inbox-reader branch January 28, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlasmaPower PlasmaPower PlasmaPower approved these changes

Assignees
No one assigned
Labels
consensus s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tristan-Wilson @PlasmaPower