Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CLI option for the RPC “finalized” and "safe" block to wait for the block validator to complete #2086

Merged
merged 7 commits into from
Feb 6, 2024
Merged

Add a CLI option for the RPC “finalized” and "safe" block to wait for the block validator to complete #2086

merged 7 commits into from
Feb 6, 2024

Conversation

amsanghi
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jan 19, 2024
@amsanghi amsanghi marked this pull request as ready for review January 19, 2024 09:12
magicxyyz
magicxyyz reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but I have few questions about locking BlockValidator.reorgMutex

staker/block_validator.go Outdated Show resolved Hide resolved
arbnode/sync_monitor.go Outdated Show resolved Hide resolved
@amsanghi amsanghi requested a review from tsahee February 6, 2024 15:49
tsahee
tsahee reviewed Feb 6, 2024
View reviewed changes
arbnode/sync_monitor.go Outdated Show resolved Hide resolved
staker/block_validator.go Outdated Show resolved Hide resolved
magicxyyz
magicxyyz approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit a7026a7 into master Feb 6, 2024
8 checks passed
@joshuacolvin0 joshuacolvin0 deleted the cli_finalized branch February 6, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsahee tsahee tsahee left review comments

@magicxyyz magicxyyz magicxyyz approved these changes

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amsanghi @magicxyyz @tsahee @joshuacolvin0