Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix starting second node in pruning system test #2073

Merged
merged 7 commits into from
Jan 29, 2024
Merged

Fix starting second node in pruning system test #2073

merged 7 commits into from
Jan 29, 2024

Conversation

magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented Jan 11, 2024 •
edited
Loading

This PR fixes starting second node in pruning test and adds a check that traverses state tries from last execConfig.Caching.BlockCount blocks.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jan 11, 2024
@notion-workspace Notion Workspace
Copy link

Fix pruning system test

ganeshvanahalli
ganeshvanahalli approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magicxyyz magicxyyz enabled auto-merge January 29, 2024 12:23
@magicxyyz magicxyyz merged commit b16a3b5 into master Jan 29, 2024
8 checks passed
@magicxyyz magicxyyz deleted the fix-pruning-test branch January 29, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuacolvin0 joshuacolvin0 joshuacolvin0 left review comments

@ganeshvanahalli ganeshvanahalli ganeshvanahalli approved these changes

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magicxyyz @ganeshvanahalli @joshuacolvin0