Sys tests wait for consensus #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't need interface since we separated headerreader from arbnode
In tests all blocks are marked safe as published immediately but not atomically, which creates some race conditions. Avoid race conditions by only considering blocks published if consensus saw them.
To avoid race conditions, make sure simulated consensus also saw the block.
make sure each transaction is received before moving forward.
cla-bot
bot
added
the
s
Tristan-Wilson
approved these changes
Nov 20, 2023
| @@ -122,19 +122,19 @@ func deployChallengeFactory(ctx context.Context, l1Reader *headerreader.HeaderRe | |||
| return common.Address{}, common.Address{}, fmt.Errorf("osp0 deploy error: %w", err) | |||
| } | |||
|
|
|||
| ospMem, _, _, err := ospgen.DeployOneStepProverMemory(auth, client) | |||
| ospMem, tx, _, err := ospgen.DeployOneStepProverMemory(auth, client) | |||
| err = andTxSucceeded(ctx, l1Reader, tx, err) | |||
There was a problem hiding this comment.
Nice find, looks like we weren't waiting for the right tx here before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes race condition in sys_tests (mostly seen in MAC).
It also sorts out and simplifies some related code, by removing the unnecessary headerreader interfaces, and moving rollup deploy code to a separate package.