Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop initializing conf field that doesn't exist anymore #1963

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

anodar
Copy link
Contributor

@anodar anodar commented Nov 13, 2023

The bug was introduced in: d53b1bc, where I dropped unused fields but not their initialization.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Nov 13, 2023
@anodar anodar marked this pull request as ready for review November 13, 2023 16:12
@anodar anodar enabled auto-merge November 13, 2023 18:51
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #1963 (665ebd5) into master (4b5133e) will decrease coverage by 4.14%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1963      +/-   ##
==========================================
- Coverage   28.83%   24.69%   -4.14%     
==========================================
  Files         220      206      -14     
  Lines       33225    29046    -4179     
==========================================
- Hits         9580     7173    -2407     
+ Misses      22575    20643    -1932     
- Partials     1070     1230     +160     

@anodar anodar merged commit 3f78331 into master Nov 17, 2023
14 checks passed
@anodar anodar deleted the fix-broken-kegen branch November 17, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants