Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain new feed messages when cache is cleared #1945

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Retain new feed messages when cache is cleared #1945

merged 2 commits into from
Nov 2, 2023

Conversation

ganeshvanahalli
Copy link
Contributor

Inside addMessagesAndEndBatchImpl before the events clearQueueOnSuccess is set to true and cache is cleared i.e while writing the messages to DB, new feed messages might get added to the cache and those shouldn't be cleared. This PR implements that.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Oct 27, 2023
@joshuacolvin0 joshuacolvin0 requested a review from anodar October 30, 2023 23:37
anodar
anodar approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@anodar anodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have unit tests for any nontrivial changes, but I understand that it's hard with the current code. We really should consider refactoring it to make testing possible/easier.

@ganeshvanahalli ganeshvanahalli merged commit ed4ec22 into master Nov 2, 2023
7 checks passed
@ganeshvanahalli ganeshvanahalli deleted the improve-txstreamer-cacheclear branch November 2, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anodar anodar anodar approved these changes

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganeshvanahalli @anodar