Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent double v in reported version #1942

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Prevent double v in reported version #1942

merged 3 commits into from
Oct 26, 2023

Conversation

joshuacolvin0
Copy link
Member

#1935

Ensure that web3_clientVersion does not have extra v included

@joshuacolvin0
Prevent double v in reported version
e8f0619 
#1935

Ensure that `web3_clientVersion` does not have extra `v` included
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Oct 26, 2023
@PlasmaPower
Copy link
Collaborator

Is there a potential crash if the vcsVersion is empty?

@joshuacolvin0
Fix issue attempting to access empty string
ed5694b 
Also remove code duplication
magicxyyz
magicxyyz approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit 8febcd5 into master Oct 26, 2023
7 checks passed
@joshuacolvin0 joshuacolvin0 deleted the version-string branch October 26, 2023 21:57
@joshuacolvin0 joshuacolvin0 mentioned this pull request Nov 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicxyyz magicxyyz magicxyyz approved these changes

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuacolvin0 @PlasmaPower @magicxyyz