Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor System Tests #1936

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Refactor System Tests #1936

merged 4 commits into from
Oct 30, 2023

Conversation

ganeshvanahalli
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli commented Oct 24, 2023 •
edited
Loading

This PR refactors System Tests to use NodeBuilder in the place of create... functions.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Oct 24, 2023
@ganeshvanahalli ganeshvanahalli marked this pull request as ready for review October 25, 2023 16:50
@ganeshvanahalli ganeshvanahalli merged commit ab694f2 into master Oct 30, 2023
7 checks passed
@ganeshvanahalli ganeshvanahalli deleted the system-tests-refactor branch October 30, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amsanghi amsanghi amsanghi approved these changes

@PlasmaPower PlasmaPower Awaiting requested review from PlasmaPower

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganeshvanahalli @amsanghi