Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using actions-rs #1934

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Stop using actions-rs #1934

merged 3 commits into from
Oct 20, 2023

Conversation

joshuacolvin0
Copy link
Member

@joshuacolvin0 joshuacolvin0 commented Oct 19, 2023

actions-rs is no longer maintained, and uses github actions features that are deprecated.
Also updated to use latest versions of various 3rd party actions

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Oct 19, 2023
Old versions of docker and golangci actions used deprecated github actions methods

`The CODEQL_EXTRACTOR_GO_BUILD_TRACING environment variable has no effect on workflows with manual build steps, so we recommend that you remove it from your workflow.`
`skip-go-installation` is no longer an option for `golangci/golangci-lint-action`
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #1934 (1e1a378) into master (d9f5a1a) will increase coverage by 28.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1934       +/-   ##
===========================================
+ Coverage   28.98%   56.99%   +28.01%     
===========================================
  Files         220      231       +11     
  Lines       33022    34789     +1767     
===========================================
+ Hits         9571    19829    +10258     
+ Misses      22393    12532     -9861     
- Partials     1058     2428     +1370     

@joshuacolvin0 joshuacolvin0 merged commit 662c401 into master Oct 20, 2023
8 checks passed
@joshuacolvin0 joshuacolvin0 deleted the actions-rs branch October 20, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants