Code

Relay WebSocket library refactor#1930

Code

Merged

PlasmaPower merged 53 commits intomasterOffchainLabs/nitro:masterfrom cl/relay-refactorOffchainLabs/nitro:cl/relay-refactorCopy head branch name to clipboardDec 13, 2023

+1,291-692

Commits

Commits on Nov 14, 2023

• Move Broadcast message objects to separate library

  lambchr

  committed
  43b12ef

• Create backlog library

  lambchr

  committed
  3f119a4

• create a race condition test for backlog library

  lambchr

  committed
  342e3c9

• fix backlog race conditions

  lambchr

  committed
  b55d38e

• add delete method to race condition test

  lambchr

  committed
  fc4db62

• swap catchupbuffer for backlog in wsbroadcastserver

  lambchr

  committed
  d805660

• fix go vet errors

  lambchr

  committed
  54ea210

• use Lookup() and requestedSeqNum instead of Head() when sending messages from the backlog

  lambchr

  committed
  946046a

• change warn to error

  lambchr

  committed
  ff440a4

• change lookupByIndex map values from atomic pointer to backlogSegment to normal pointer to backlogSegment

  lambchr

  committed
  5d36e6b

• remove max catchup TODO - not necessary

  lambchr

  committed
  bff53fc

• fix broadcaster tests after Head -> Lookup change in clientconnection

  lambchr

  committed
  1faa39e

• fix broadcast client invalid signature test

  lambchr

  committed
  06d72a8

• fix backlog sending duplicate messages to clients

  lambchr

  committed
  a0bf64b

• fix BroadcastClient test TestBroadcastClientConfirmedMessage

  lambchr

  committed
  1858770

• move flateWriter to serializeMessage to avoid race condition

  lambchr

  committed
  66357cf

• refactor ClientConnection to stop relying on ClientManager - CM will pass down the required channel to communicate with each CC

  lambchr

  committed
  b046b8f

• refactor backlog to allow deletion of all confirmed messages from segments

  lambchr

  committed
  7cf1b2b

• fix messages in broadcastclients

  lambchr

  committed
  a265e27

• fix lint errors

  lambchr

  committed
  617c0d6

Commits on Nov 15, 2023

• remove unnecessary exported functions from BacklogSegment interface and recreate the Contains method

  lambchr

  committed
  8e72df6

• ensure the ClientConnection only sends the requested messages to the client rather than the whole segment

  lambchr

  committed
  ea46fd9

• fix backlog lint error

  lambchr

  committed
  60ce382

Commits on Nov 16, 2023

• ensure WSBroadcast server sends the whole backlog when the requested seq num is lower than what is in the backlog

  lambchr

  committed
  5e2f1aa

• add comments to backlog functions

  lambchr

  committed
  812e7a6

Commits on Nov 30, 2023

• change lookupByKey to containers.SyncMap and remove lookupLock

  lambchr

  committed
  0be22bc

• fix log.info line

  lambchr

  committed
  ffa6636

• fix potential delete race condition in backlog.Get

  lambchr

  committed
  3403b7b

• remove backlogSegment type assertion

  lambchr

  committed
  d9d479d

• remove backlogSegment.start, backlogSegment.end and backlogSegment.messageCount, use the backlogSegment.messagesLock to calculate these when required

  lambchr

  committed
  1fc038c

• fix go vet errors from containers.SyncMap addition, change to a pointer to containers.SyncMap

  lambchr

  committed
  11e26ed

• return nil interface from backlogSegment.Next rather than nil *backlogSegment

  lambchr

  committed
  c098840

• return copies of messages slice from backlogSegment.Get and backlogSegment.Messages

  lambchr

  committed
  ccb6499

• get messagesLock for entire backlogSegment.Get and

  Show description for 2537247
  lambchr

  committed
  2537247

• remove metric TODO

  lambchr

  committed
  369b5ea

Commits on Dec 1, 2023

• use length of messages slice in copy rather than segment limit to avoid slice being populated with nils

  lambchr

  committed
  c86fcfd

• change IsBacklogSegmentNil to check for nil interface as backlogSegment.Next now returns a nil interface

  lambchr

  committed
  b706481

• add version as a constant to messages lib

  lambchr

  committed
  7334858

Commits on Dec 4, 2023

• Merge branch 'master' into cl/relay-refactor

  lambchr

  authored
  20e5d69

• correct broadcaster lib

  lambchr

  committed
  39514fc

• only send one message with the confirmed sequence number

  lambchr

  committed
  6d1eca1

• add comment explaining additional doBroadcast call for confirmed messages

  lambchr

  committed
  ebed210

• move last sent sequence number check from client manager to client connection

  lambchr

  committed
  fb17717

• fix sending only 1 message on confirm

  lambchr

  committed
  93144bf

• change warn to debug

  lambchr

  committed
  4238891

• fix moving last sent check

  lambchr

  committed
  0bd866a

Commits on Dec 11, 2023

• remove recursive lock calls from backlogSegment object

  lambchr

  committed
  fed7de2

• reload head after lookup call

  lambchr

  committed
  5a7ac9e

• fix no new var error

  lambchr

  committed
  3b4c9b6

• change copy slice to only copy the selected elements

  lambchr

  committed
  da08db5

Commits on Dec 13, 2023

• remove recursive lock calls from backlogSegment object

  lambchr

  committed
  69e8dde

• Merge branch 'master' into cl/relay-refactor

  PlasmaPower

  authored
  756f616

• Merge branch 'master' into cl/relay-refactor

  PlasmaPower

  authored
  4b66827