Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to time each part of WSBroadcastServer’s StartWithHeader #1926

Merged
merged 9 commits into from
Oct 26, 2023
Merged

Add metrics to time each part of WSBroadcastServer’s StartWithHeader #1926

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
927a760
Add metrics to time each part of WSBroadcastServer’s StartWithHeader
ganeshvanahalli Oct 16, 2023
c7ca05a
Merge branch 'master' into add-metrics-wsbserver
ganeshvanahalli Oct 16, 2023
b49e103
refactor
ganeshvanahalli Oct 16, 2023
a430014
code refactor
ganeshvanahalli Oct 24, 2023
71ed70b
Merge branch 'master' into add-metrics-wsbserver
ganeshvanahalli Oct 24, 2023
0e9445d
Update wsbroadcastserver/wsbroadcastserver.go
ganeshvanahalli Oct 25, 2023
70df6d6
code refactor
ganeshvanahalli Oct 25, 2023
e88f53e
Update wsbroadcastserver.go
ganeshvanahalli Oct 26, 2023
43e3ec8
Merge branch 'master' into add-metrics-wsbserver
joshuacolvin0 Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion wsbroadcastserver/wsbroadcastserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
flag "github.com/spf13/pflag"

"github.com/ethereum/go-ethereum/log"
"github.com/ethereum/go-ethereum/metrics"
"github.com/offchainlabs/nitro/arbutil"
)

Expand All @@ -32,6 +33,8 @@ var (
HTTPHeaderFeedClientVersion = textproto.CanonicalMIMEHeaderKey("Arbitrum-Feed-Client-Version")
HTTPHeaderRequestedSequenceNumber = textproto.CanonicalMIMEHeaderKey("Arbitrum-Requested-Sequence-Number")
HTTPHeaderChainId = textproto.CanonicalMIMEHeaderKey("Arbitrum-Chain-Id")
upgradeToWSTimer = metrics.NewRegisteredTimer("arb/feed/clients/upgrade/duration", nil)
startWithHeaderTimer = metrics.NewRegisteredTimer("arb/feed/clients/start/duration", nil)
)

const (
Expand Down Expand Up @@ -201,7 +204,11 @@ func (s *WSBroadcastServer) Start(ctx context.Context) error {
HTTPHeaderChainId: []string{strconv.FormatUint(s.chainId, 10)},
})

return s.StartWithHeader(ctx, header)
startTime := time.Now()
err := s.StartWithHeader(ctx, header)
elapsed := time.Since(startTime)
startWithHeaderTimer.Update(elapsed)
return err
}

func (s *WSBroadcastServer) StartWithHeader(ctx context.Context, header ws.HandshakeHeader) error {
Expand Down Expand Up @@ -316,7 +323,10 @@ func (s *WSBroadcastServer) StartWithHeader(ctx context.Context, header ws.Hands
}

// Zero-copy upgrade to WebSocket connection.
startTime := time.Now()
_, err = upgrader.Upgrade(conn)
elapsed := time.Since(startTime)
upgradeToWSTimer.Update(elapsed)

if err != nil {
if err.Error() != "" {
Expand Down
Loading