Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --log-type option for daserver #1925

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

Tristan-Wilson
Copy link
Member

This adds the ability to have json logs.

Testing done

$ ./target/bin/daserver --conf.file ../nitro/datestconf/mainnet-ipfs-mirror.conf --log-type json
{"err":"Post \"https://abc.def\": dial tcp: lookup abc.def: no such host","lvl":"eror","msg":"Error running DAServer","t":"2023-10-16T17:39:55.376489742+02:00"}
$ ./target/bin/daserver --conf.file ../nitro/datestconf/mainnet-ipfs-mirror.conf
ERROR[10-16|17:40:01.001] Error running DAServer                   err="Post \"https://abc.def\": dial tcp: lookup abc.def: no such host"

This adds the ability to have json logs.
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Oct 16, 2023
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tristan-Wilson Tristan-Wilson merged commit 7c8eae8 into master Oct 16, 2023
7 checks passed
@Tristan-Wilson Tristan-Wilson deleted the json-log-type-daserver branch October 16, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants