Add triedb race test

execution/gethexec/node.go

@@ -114,6 +114,7 @@ func ConfigDefaultTest() *Config {
 	config.ParentChainReader = headerreader.Config{}
 	config.Sequencer = TestSequencerConfig
 	config.ForwardingTarget = "null"
+	config.ParentChainReader = headerreader.TestConfig
 
 	_ = config.Validate()
 

system_tests/recreatestate_rpc_test.go

@@ -97,9 +97,8 @@ func TestRecreateStateForRPCNoDepthLimit(t *testing.T) {
 	nodeConfig.Sequencer.MaxBlockSpeed = 0
 	nodeConfig.Sequencer.MaxTxDataSize = 150 // 1 test tx ~= 110
 	nodeConfig.Caching.Archive = true
-	// disable caching of states in BlockChain.stateCache
+	// disable trie/Database.cleans cache, so as states removed from ChainDb won't be cached there
 	nodeConfig.Caching.TrieCleanCache = 0
-	nodeConfig.Caching.TrieDirtyCache = 0
 	nodeConfig.Caching.MaxNumberOfBlocksToSkipStateSaving = 0
 	nodeConfig.Caching.MaxAmountOfGasToSkipStateSaving = 0
 	_, execNode, l2client, cancelNode := prepareNodeWithHistory(t, ctx, nodeConfig, 32)
@@ -121,7 +120,6 @@ func TestRecreateStateForRPCNoDepthLimit(t *testing.T) {
 	if balance.Cmp(expectedBalance) != 0 {
 		Fatal(t, "unexpected balance result for last block, want: ", expectedBalance, " have: ", balance)
 	}
-
 }
 
 func TestRecreateStateForRPCBigEnoughDepthLimit(t *testing.T) {
@@ -133,9 +131,8 @@ func TestRecreateStateForRPCBigEnoughDepthLimit(t *testing.T) {
 	nodeConfig.Sequencer.MaxBlockSpeed = 0
 	nodeConfig.Sequencer.MaxTxDataSize = 150 // 1 test tx ~= 110
 	nodeConfig.Caching.Archive = true
-	// disable caching of states in BlockChain.stateCache
+	// disable trie/Database.cleans cache, so as states removed from ChainDb won't be cached there
 	nodeConfig.Caching.TrieCleanCache = 0
-	nodeConfig.Caching.TrieDirtyCache = 0
 	nodeConfig.Caching.MaxNumberOfBlocksToSkipStateSaving = 0
 	nodeConfig.Caching.MaxAmountOfGasToSkipStateSaving = 0
 	_, execNode, l2client, cancelNode := prepareNodeWithHistory(t, ctx, nodeConfig, 32)
@@ -168,9 +165,8 @@ func TestRecreateStateForRPCDepthLimitExceeded(t *testing.T) {
 	nodeConfig.Sequencer.MaxBlockSpeed = 0
 	nodeConfig.Sequencer.MaxTxDataSize = 150 // 1 test tx ~= 110
 	nodeConfig.Caching.Archive = true
-	// disable caching of states in BlockChain.stateCache
+	// disable trie/Database.cleans cache, so as states removed from ChainDb won't be cached there
 	nodeConfig.Caching.TrieCleanCache = 0
-	nodeConfig.Caching.TrieDirtyCache = 0
 	nodeConfig.Caching.MaxNumberOfBlocksToSkipStateSaving = 0
 	nodeConfig.Caching.MaxAmountOfGasToSkipStateSaving = 0
 	_, execNode, l2client, cancelNode := prepareNodeWithHistory(t, ctx, nodeConfig, 32)
@@ -203,9 +199,8 @@ func TestRecreateStateForRPCMissingBlockParent(t *testing.T) {
 	nodeConfig.Sequencer.MaxBlockSpeed = 0
 	nodeConfig.Sequencer.MaxTxDataSize = 150 // 1 test tx ~= 110
 	nodeConfig.Caching.Archive = true
-	// disable caching of states in BlockChain.stateCache
+	// disable trie/Database.cleans cache, so as states removed from ChainDb won't be cached there
 	nodeConfig.Caching.TrieCleanCache = 0
-	nodeConfig.Caching.TrieDirtyCache = 0
 	nodeConfig.Caching.MaxNumberOfBlocksToSkipStateSaving = 0
 	nodeConfig.Caching.MaxAmountOfGasToSkipStateSaving = 0
 	_, execNode, l2client, cancelNode := prepareNodeWithHistory(t, ctx, nodeConfig, headerCacheLimit+5)
@@ -249,9 +244,8 @@ func TestRecreateStateForRPCBeyondGenesis(t *testing.T) {
 	nodeConfig.Sequencer.MaxBlockSpeed = 0
 	nodeConfig.Sequencer.MaxTxDataSize = 150 // 1 test tx ~= 110
 	nodeConfig.Caching.Archive = true
-	// disable caching of states in BlockChain.stateCache
+	// disable trie/Database.cleans cache, so as states removed from ChainDb won't be cached there
 	nodeConfig.Caching.TrieCleanCache = 0
-	nodeConfig.Caching.TrieDirtyCache = 0
 	nodeConfig.Caching.MaxNumberOfBlocksToSkipStateSaving = 0
 	nodeConfig.Caching.MaxAmountOfGasToSkipStateSaving = 0
 	_, execNode, l2client, cancelNode := prepareNodeWithHistory(t, ctx, nodeConfig, 32)
@@ -285,9 +279,9 @@ func TestRecreateStateForRPCBlockNotFoundWhileRecreating(t *testing.T) {
 	nodeConfig.Sequencer.MaxBlockSpeed = 0
 	nodeConfig.Sequencer.MaxTxDataSize = 150 // 1 test tx ~= 110
 	nodeConfig.Caching.Archive = true
-	// disable caching of states in BlockChain.stateCache
+	// disable trie/Database.cleans cache, so as states removed from ChainDb won't be cached there
 	nodeConfig.Caching.TrieCleanCache = 0
-	nodeConfig.Caching.TrieDirtyCache = 0
+
 	nodeConfig.Caching.MaxNumberOfBlocksToSkipStateSaving = 0
 	nodeConfig.Caching.MaxAmountOfGasToSkipStateSaving = 0
 	_, execNode, l2client, cancelNode := prepareNodeWithHistory(t, ctx, nodeConfig, blockCacheLimit+4)
@@ -421,6 +415,9 @@ func testSkippingSavingStateAndRecreatingAfterRestart(t *testing.T, cacheConfig
 	}
 	for i := genesis + 1; i <= genesis+uint64(txCount); i += i % 10 {
 		_, err = client.BalanceAt(ctx, GetTestAddressForAccountName(t, "User2"), new(big.Int).SetUint64(i))
+		if err != nil {
+			t.Log("skipBlocks:", skipBlocks, "skipGas:", skipGas)
+		}
 		Require(t, err)
 	}
 
@@ -434,10 +431,7 @@ func testSkippingSavingStateAndRecreatingAfterRestart(t *testing.T, cacheConfig
 func TestSkippingSavingStateAndRecreatingAfterRestart(t *testing.T) {
 	cacheConfig := gethexec.DefaultCachingConfig
 	cacheConfig.Archive = true
-	// disable caching of states in BlockChain.stateCache
-	cacheConfig.TrieCleanCache = 0
-	cacheConfig.TrieDirtyCache = 0
-	// test defaults
+	//// test defaults
 	testSkippingSavingStateAndRecreatingAfterRestart(t, &cacheConfig, 512)
 
 	cacheConfig.MaxNumberOfBlocksToSkipStateSaving = 127

system_tests/triedb_race_test.go

@@ -0,0 +1,84 @@
+package arbtest
+
+import (
+	"context"
+	"sync"
+	"testing"
+	"time"
+
+	"github.com/ethereum/go-ethereum/arbitrum"
+	"github.com/ethereum/go-ethereum/common"
+	"github.com/ethereum/go-ethereum/log"
+	"github.com/ethereum/go-ethereum/rpc"
+	"github.com/offchainlabs/nitro/execution/gethexec"
+	"github.com/offchainlabs/nitro/util/testhelpers"
+)
+
+func TestTrieDBCommitRace(t *testing.T) {
+	_ = testhelpers.InitTestLog(t, log.LvlError)
+	ctx, cancel := context.WithCancel(context.Background())
+	defer cancel()
+	execConfig := gethexec.ConfigDefaultTest()
+	execConfig.RPC.MaxRecreateStateDepth = arbitrum.InfiniteMaxRecreateStateDepth
+	execConfig.Sequencer.MaxBlockSpeed = 0
+	execConfig.Sequencer.MaxTxDataSize = 150 // 1 test tx ~= 110
+	execConfig.Caching.Archive = true
+	execConfig.Caching.BlockCount = 127
+	execConfig.Caching.BlockAge = 0
+	execConfig.Caching.MaxNumberOfBlocksToSkipStateSaving = 127
+	execConfig.Caching.MaxAmountOfGasToSkipStateSaving = 0
+	l2info, node, l2client, _, _, _, l1stack := createTestNodeOnL1WithConfig(t, ctx, true, nil, execConfig, nil, nil)
+	cancel = func() {
+		defer requireClose(t, l1stack)
+		defer node.StopAndWait()
+	}
+	defer cancel()
+	execNode := getExecNode(t, node)
+	l2info.GenerateAccount("User2")
+	bc := execNode.Backend.ArbInterface().BlockChain()
+
+	var wg sync.WaitGroup
+	quit := make(chan struct{})
+	wg.Add(1)
+	go func() {
+		defer wg.Done()
+		for {
+			select {
+			default:
+				TransferBalance(t, "Faucet", "User2", common.Big1, l2info, l2client, ctx)
+			case <-quit:
+				return
+			}
+		}
+	}()
+	api := execNode.Backend.APIBackend()
+	blockNumber := 1
+	for i := 0; i < 5; i++ {
+		var roots []common.Hash
+		for len(roots) < 1024 {
+			select {
+			default:
+				block, err := api.BlockByNumber(ctx, rpc.BlockNumber(blockNumber))
+				if err == nil && block != nil {
+					root := block.Root()
+					if statedb, err := bc.StateAt(root); err == nil {
+						err := statedb.Database().TrieDB().Reference(root, common.Hash{})
+						Require(t, err)
+						roots = append(roots, root)
+					}
+					blockNumber += 1
+				}
+			case <-quit:
+				return
+			}
+		}
+		t.Log("dereferencing...")
+		for _, root := range roots {
+			err := bc.TrieDB().Dereference(root)
+			Require(t, err)
+			time.Sleep(1)
+		}
+	}
+	close(quit)
+	wg.Wait()
+}