Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add secondary feed to go relay #1908

Merged
merged 9 commits into from
Oct 26, 2023
Merged

add secondary feed to go relay #1908

merged 9 commits into from
Oct 26, 2023

Conversation

ganeshvanahalli
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli commented Oct 9, 2023

introduce a router model for BroadcastClients that routes messages from upstream (sequencer feeds) to downstream (node or relay), with added capacity of starting new upstream feeds (secondary-url) if primary feed (url) seems to be failing i.e no new messages for a period of 5 seconds.

The router model also disconnects the recently started secondary feed in case the primary feeds are up without a failure for more than 10 minutes.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Oct 9, 2023
@ganeshvanahalli ganeshvanahalli marked this pull request as ready for review October 10, 2023 14:54
@Tristan-Wilson
Copy link
Member

A description of the change and details of any testing you've done would be helpful for the reviewers and anyone who comes back to look at this later.

broadcastclient/broadcastclient.go Outdated Show resolved Hide resolved
broadcastclients/broadcastclients.go Outdated Show resolved Hide resolved
Tristan-Wilson
Tristan-Wilson previously approved these changes Oct 26, 2023
Copy link
Member

@Tristan-Wilson Tristan-Wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor nit.

@ganeshvanahalli ganeshvanahalli merged commit e113afb into master Oct 26, 2023
7 checks passed
@ganeshvanahalli ganeshvanahalli deleted the secondary-relay-feed branch October 26, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants