Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add access list entries for dynamic storage slots for bridge contract #1907

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Add access list entries for dynamic storage slots for bridge contract #1907

merged 6 commits into from
Oct 10, 2023

Conversation

anodar
Copy link
Contributor

@anodar anodar commented Oct 9, 2023

No description provided.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Oct 9, 2023
@anodar anodar requested a review from PlasmaPower October 9, 2023 14:46
@anodar anodar marked this pull request as ready for review October 9, 2023 14:46
Base automatically changed from access-lists to master October 9, 2023 16:44
@anodar anodar requested a review from amsanghi October 9, 2023 16:45
amsanghi
amsanghi previously approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@amsanghi amsanghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Left couple of minor suggestions, ok to not implement them if you don't agree.

arbutil/hash.go Outdated Show resolved Hide resolved
arbnode/batch_poster.go Outdated Show resolved Hide resolved
@anodar anodar requested a review from amsanghi October 10, 2023 17:38
@anodar
Copy link
Contributor Author

anodar commented Oct 10, 2023

Thanks for the review! Applied suggestions, ptal.

@anodar anodar merged commit c7ebb80 into master Oct 10, 2023
7 checks passed
@anodar anodar deleted the access-lists-cont branch October 10, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amsanghi amsanghi amsanghi approved these changes

@PlasmaPower PlasmaPower Awaiting requested review from PlasmaPower

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anodar @amsanghi