-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BOLD System Test That Successfully Completes a Challenge #1902
Conversation
@@ -313,7 +313,8 @@ func (s *HeaderReader) logIfHeaderIsOld() { | |||
} | |||
l1Timetamp := time.Unix(int64(storedHeader.Time), 0) | |||
headerTime := time.Since(l1Timetamp) | |||
if headerTime >= s.config().OldHeaderTimeout { | |||
oldHeaderTimeout := time.Minute * 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to figure out how to override this in our test...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing it here https://github.com/OffchainLabs/nitro/blob/master/util/headerreader/header_reader.go#L94 should do the trick i think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Huge thank you for this.
Ok to merge in bold branch for now, but before merging in to the master, I'd say let's have Lee's/Tsahi's review for validator folder at least.
@@ -313,7 +313,8 @@ func (s *HeaderReader) logIfHeaderIsOld() { | |||
} | |||
l1Timetamp := time.Unix(int64(storedHeader.Time), 0) | |||
headerTime := time.Since(l1Timetamp) | |||
if headerTime >= s.config().OldHeaderTimeout { | |||
oldHeaderTimeout := time.Minute * 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing it here https://github.com/OffchainLabs/nitro/blob/master/util/headerreader/header_reader.go#L94 should do the trick i think.
Thanks for the review ! Definitely needs a lot of review before it can make it into master, but with this, we'll have the bold branch in nitro updated with master and working |
This PR makes the following changes to Nitro for the BOLD protocol:
main
GetLeavesWithStepSize
to deal with the more complex requirements of BOLD. Here's what it does:keccak256("Machine finished:", machine.GlobalState().Hash())
stepSize
increments until the machine is finished