Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test-gen-proofs with single thread #1894

Closed
wants to merge 1 commit into from

Conversation

joshuacolvin0
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Sep 28, 2023
PlasmaPower
PlasmaPower previously approved these changes Sep 28, 2023
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower
Copy link
Collaborator

This does not seem to make CI faster unfortunately. I think some level of parallelism is necessary for reasonable CI times here.

@PlasmaPower PlasmaPower dismissed their stale review September 28, 2023 01:43

doesn't seem to make CI faster

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #1894 (240ed8d) into master (f2e6aa2) will decrease coverage by 0.25%.
Report is 10 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1894      +/-   ##
==========================================
- Coverage   28.49%   28.25%   -0.25%     
==========================================
  Files         218      218              
  Lines       32846    32846              
==========================================
- Hits         9360     9279      -81     
- Misses      22435    22501      +66     
- Partials     1051     1066      +15     

@joshuacolvin0
Copy link
Member Author

This makes arbitrator ci take 4 hours instead of 1 hour 20 minutes, so definitely slower

@joshuacolvin0 joshuacolvin0 deleted the arbitrator-ci-parallel branch September 28, 2023 06:36
@AiyAbuya AiyAbuya mentioned this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants