Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to dataposter and clear leveldb when that flag is set #1872

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

anodar
Copy link
Contributor

@anodar anodar commented Sep 19, 2023

No description provided.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Sep 19, 2023
@anodar anodar marked this pull request as ready for review September 19, 2023 13:47
@anodar anodar requested a review from PlasmaPower September 19, 2023 13:47
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #1872 (9fd0ff5) into master (b359dbc) will decrease coverage by 2.82%.
The diff coverage is 64.28%.

❗ Current head 9fd0ff5 differs from pull request most recent head 11a2a3c. Consider uploading reports for the commit 11a2a3c to get more accurate results

@@            Coverage Diff             @@
##           master    #1872      +/-   ##
==========================================
- Coverage   56.78%   53.97%   -2.82%     
==========================================
  Files         228      215      -13     
  Lines       34436    30272    -4164     
==========================================
- Hits        19556    16338    -3218     
+ Misses      12467    11514     -953     
- Partials     2413     2420       +7     

Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anodar anodar merged commit 461369d into master Sep 27, 2023
7 checks passed
@anodar anodar deleted the flag-for-clearing-leveldb branch September 27, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants