Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add methods to configure brotli compression level in ArbOS 12 #1865

Merged
merged 13 commits into from
Sep 28, 2023

Conversation

ganeshvanahalli
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli commented Sep 15, 2023

PR for contracts - OffchainLabs/nitro-contracts#63

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #1865 (3234af9) into master (15ea478) will increase coverage by 0.04%.
The diff coverage is 34.32%.

@@            Coverage Diff             @@
##           master    #1865      +/-   ##
==========================================
+ Coverage   28.31%   28.36%   +0.04%     
==========================================
  Files         218      218              
  Lines       32875    32925      +50     
==========================================
+ Hits         9308     9338      +30     
- Misses      22504    22527      +23     
+ Partials     1063     1060       -3     

joshuacolvin0
joshuacolvin0 previously approved these changes Sep 26, 2023
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arbos/l1pricing/l1pricing.go Outdated Show resolved Hide resolved
arbcompress/compress_common.go Outdated Show resolved Hide resolved
@AiyAbuya AiyAbuya mentioned this pull request Sep 28, 2023
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit 88b10f1 into master Sep 28, 2023
8 checks passed
@joshuacolvin0 joshuacolvin0 deleted the add-brotlilevel-methods branch September 28, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArbOS consensus contracts s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants