Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new RPC GetL2BlockRangeForL1 to fetch L2 block range for L1 block number #1860

Merged
merged 12 commits into from
Sep 25, 2023

Conversation

ganeshvanahalli
Copy link
Contributor

PR for go-ethereum - OffchainLabs/go-ethereum#254
PR for contracts - OffchainLabs/nitro-contracts#62

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #1860 (39ce1b4) into master (affaf25) will increase coverage by 0.31%.
The diff coverage is 55.00%.

@@            Coverage Diff             @@
##           master    #1860      +/-   ##
==========================================
+ Coverage   56.48%   56.79%   +0.31%     
==========================================
  Files         228      228              
  Lines       34443    34503      +60     
==========================================
+ Hits        19454    19597     +143     
+ Misses      12560    12494      -66     
+ Partials     2429     2412      -17     

nodeInterface/NodeInterface.go Outdated Show resolved Hide resolved
nodeInterface/NodeInterface.go Outdated Show resolved Hide resolved
nodeInterface/NodeInterface.go Outdated Show resolved Hide resolved
nodeInterface/NodeInterface.go Outdated Show resolved Hide resolved
nodeInterface/NodeInterface.go Outdated Show resolved Hide resolved
system_tests/nodeinterface_test.go Outdated Show resolved Hide resolved
system_tests/nodeinterface_test.go Outdated Show resolved Hide resolved
system_tests/nodeinterface_test.go Outdated Show resolved Hide resolved
nodeInterface/NodeInterface.go Outdated Show resolved Hide resolved
system_tests/nodeinterface_test.go Outdated Show resolved Hide resolved
nodeInterface/NodeInterface.go Outdated Show resolved Hide resolved
system_tests/nodeinterface_test.go Outdated Show resolved Hide resolved
system_tests/nodeinterface_test.go Outdated Show resolved Hide resolved
nodeInterface/NodeInterface.go Outdated Show resolved Hide resolved
system_tests/nodeinterface_test.go Outdated Show resolved Hide resolved
system_tests/nodeinterface_test.go Outdated Show resolved Hide resolved
nodeInterface/NodeInterface.go Show resolved Hide resolved
nodeInterface/NodeInterface.go Outdated Show resolved Hide resolved
system_tests/nodeinterface_test.go Outdated Show resolved Hide resolved
nodeInterface/NodeInterface.go Outdated Show resolved Hide resolved
anodar
anodar previously approved these changes Sep 25, 2023
Copy link
Contributor

@anodar anodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments!

@ganeshvanahalli ganeshvanahalli merged commit c86cf05 into master Sep 25, 2023
8 checks passed
@ganeshvanahalli ganeshvanahalli deleted the add-l2rangeforl1-rpc branch September 25, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants