Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archive expired retryables #1660

Draft
wants to merge 56 commits into
base: master
Choose a base branch
from
Draft

archive expired retryables #1660

wants to merge 56 commits into from

Conversation

magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented May 23, 2023 •
edited by joshuacolvin0
Loading

fixes NIT-2979

WIP

  • instead of just removing, store expired retryables in an accumulator
  • add support for reviving expired retryables

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label May 23, 2023
magicxyyz added 19 commits May 23, 2023 16:13
@magicxyyz
add packed set skeleton
9764d2c
@magicxyyz
use also retryable id when getting retrayable hash
c9fb42f
@magicxyyz
add storage backed Uint64Set
b0747d7
@magicxyyz
add checkValidArchivedAndRedeemable, track nonredeemable instead of r…
56a8da9 
…edeemable archived retrayables, use ticketId as key
@magicxyyz
add moveFundsLeftInEscrowToBeneficiary helper
6def19a
@magicxyyz
draft RedeemArchived
453905f
@magicxyyz
pass retryable data in RedeemArchivedScheduledEvent
deab4dc
@magicxyyz
revert some changes
9f22086
@magicxyyz
add ArbRetryableTx Revive method in place of RedeemArchive / CancelAr…
5efb550 
…chive
@magicxyyz
emit ExpiredMerkleUpdate event
b14b235
@magicxyyz
update contracts
3858e12
@magicxyyz
Merge branch 'master' into expired-retryables
b57c2f5
@magicxyyz
revert state if reaping retryable fails
eabc366
@magicxyyz
update contracts
25f7a73
@magicxyyz
emit RetryableExpired event
4e0f6ba
@magicxyyz
Merge branch 'master' into expired-retryables
26927b9
@magicxyyz
update contracts
e1eca08
@magicxyyz
fix RetryableExpired event emitting loop
86b74b2
@magicxyyz
update contracts
3d5e8de
@codecov
Copy link

codecov bot commented Jun 15, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.48796% with 296 lines in your changes missing coverage. Please review.

Project coverage is 31.08%. Comparing base (b359dbc) to head (b6f2190).
Report is 5928 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #1660       +/-   ##
===========================================
- Coverage   56.78%   31.08%   -25.71%     
===========================================
  Files         228      219        -9     
  Lines       34436    33253     -1183     
===========================================
- Hits        19556    10337     -9219     
- Misses      12467    21729     +9262     
+ Partials     2413     1187     -1226

magicxyyz and others added 17 commits June 30, 2023 02:29
@magicxyyz magicxyyz force-pushed the expired-retryables branch from 76fd4f5 to 8edc704 Compare July 11, 2023 23:30
@notion-workspace Notion Workspace
Copy link

Put expired retryables into a merkle tree accumulator instead of deleting them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@magicxyyz