[Configuration Changes] Execution service 3: initial execution-node, interface+implementation #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
It will be back from execNode's sync_monitor
Conflicts: arbnode/execution/node.go arbnode/maintenance.go arbnode/node.go cmd/nitro/init.go cmd/nitro/nitro.go execution/gethexec/sequencer.go go-ethereum system_tests/arbtrace_test.go system_tests/batch_poster_test.go system_tests/common_test.go system_tests/das_test.go system_tests/forwarder_test.go system_tests/seq_coordinator_test.go system_tests/seqfeed_test.go system_tests/staker_test.go
PlasmaPower
changed the title
PlasmaPower
requested changes
Sep 28, 2023
| execClient = nil | ||
| } | ||
| if execClient != nil { | ||
| err := execClient.Initialize(ctx, n, n.SyncMonitor) |
There was a problem hiding this comment.
Could we add Initialize and Start to the interface, or is the SyncMonitor the issue? As-is I'm a bit worried that we might miss this in a refactor and we'd forget to Initialize it.
There was a problem hiding this comment.
I don't want to add Initialize to the interface - this is very specific for the gethexec node and would e.g. be very different for a n execution RPC client.
Added Start and StopAndWait, where any client could have a reasonable implementation for these two functions.
PlasmaPower
reviewed
Sep 28, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create (non-async) API for execution client, execution node creates relevant members.
Arbnode still manages execution node, mostly to simplify changes to tests.
pulls in: OffchainLabs/go-ethereum#238