Execution service 4: execution->consensus interface #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
These tests often fail in CI because the chain doesn't move fast enough. Doing it serially should help.
DelayedMaxMessageCount is confusing with delayed inbox messages
tsahee
commented
Oct 11, 2023
arbnode/inbox_tracker.go
Outdated
| @@ -213,6 +218,44 @@ func (t *InboxTracker) GetBatchCount() (uint64, error) { | |||
| return count, nil | |||
| } | |||
|
|
|||
| func (t *InboxTracker) FindL1BatchForMessage(pos arbutil.MessageIndex) (uint64, error) { | |||
There was a problem hiding this comment.
used to be static_block_validator: FindBatchContainingMessageIndex
This reverts commit 7e82acf.
PlasmaPower
requested changes
Mar 21, 2024
| return 0, false, err | ||
| } | ||
| if lastBatchMessageCount <= pos { | ||
| return 0, false, nil |
There was a problem hiding this comment.
I'm not sure this is the right decision, but we could consider returning a special error in this case instead of having the bool return. If we stick with the bool return, we should add a comment explaining what it is.
There was a problem hiding this comment.
Specialized errors are fickle, especially in interfaces that will later be over rpc. I think a boolean makes sense here.
Added documentation. LMKWYT.
There was a problem hiding this comment.
Makes sense. I don't see the documentation there, maybe it didn't get pushed up?
PlasmaPower
reviewed
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execution now only makes requests for consensus client using a reasonbly-defined API (not yet asyncronous)
This PR mostly deals with node_interface and sync_monitor.
These two created heavy dependency of execution node in inner-consensus details.
Also classic-messages moved to execution for API simplicity.
Part of NIT-1262