Skip to content

Commit

Permalink
Skip tls verification when making requests to secure signer from Data…
Browse files Browse the repository at this point in the history
…poster
  • Loading branch information
anodar committed May 16, 2024
1 parent 51b12a6 commit bf8f40a
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions arbnode/dataposter/data_poster.go
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,10 @@ func NewDataPoster(ctx context.Context, opts *DataPosterOpts) (*DataPoster, erro
func rpcClient(ctx context.Context, opts *ExternalSignerCfg) (*rpc.Client, error) {
tlsCfg := &tls.Config{
MinVersion: tls.VersionTLS12,
// Dataposter verifies that signed transaction was signed by the account
// that it expects to be signed with. So signer is already authenticated
// on application level and does not need to rely on TLS for authentication.
InsecureSkipVerify: true, // #nosec G402

Check failure

Code scanning / CodeQL

Disabled TLS certificate check High

InsecureSkipVerify should not be used in production code.
}

if opts.ClientCert != "" && opts.ClientPrivateKey != "" {
Expand Down

0 comments on commit bf8f40a

Please sign in to comment.