Produce better error messages when failing to read the delayed inbox

OffchainLabs · Feb 8, 2024 · 668393b · 668393b
1 parent 8517340
commit 668393b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/arbnode/delayed.go b/arbnode/delayed.go
@@ -221,10 +221,10 @@ func (b *DelayedBridge) logsToDeliveredMessages(ctx context.Context, logs []type
 		msgKey := common.BigToHash(parsedLog.MessageIndex)
 		data, ok := messageData[msgKey]
 		if !ok {
-			return nil, errors.New("message not found")
+			return nil, fmt.Errorf("message %v data not found", parsedLog.MessageIndex)
 		}
 		if crypto.Keccak256Hash(data) != parsedLog.MessageDataHash {
-			return nil, errors.New("found message data with mismatched hash")
+			return nil, fmt.Errorf("found message %v data with mismatched hash", parsedLog.MessageIndex)
 		}
 
 		requestId := common.BigToHash(parsedLog.MessageIndex)

diff --git a/arbnode/inbox_tracker.go b/arbnode/inbox_tracker.go
@@ -374,11 +374,11 @@ func (t *InboxTracker) AddDelayedMessages(messages []*DelayedInboxMessage, hardR
 		}
 
 		if seqNum != pos {
-			return errors.New("unexpected delayed sequence number")
+			return fmt.Errorf("unexpected delayed sequence number %v, expected %v", seqNum, pos)
 		}
 
 		if nextAcc != message.BeforeInboxAcc {
-			return errors.New("previous delayed accumulator mismatch")
+			return fmt.Errorf("previous delayed accumulator mismatch for message %v", seqNum)
 		}
 		nextAcc = message.AfterInboxAcc()