Skip to content

Commit

Permalink
add comment to skipped error checks
Browse files Browse the repository at this point in the history
  • Loading branch information
magicxyyz committed Oct 13, 2023
1 parent 9ec92bc commit 41b9517
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions arbos/retryables/retryable.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ func (rs *RetryableState) DeleteRetryable(id common.Hash, evm *vm.EVM, scenario
return false, err
}

// we ignore returned error as we expect that if one ClearByUint64 fails, than all consecutive calls to ClearByUint64 will fail with the same error (not modifying state), and then ClearBytes will also fail with the same error (also not modifying state) - and this one we check and return
_ = retStorage.ClearByUint64(numTriesOffset)
_ = retStorage.ClearByUint64(fromOffset)
_ = retStorage.ClearByUint64(toOffset)
Expand Down

0 comments on commit 41b9517

Please sign in to comment.