don't use referencing when recovering states

OffchainLabs · Jan 30, 2024 · 2cb1342 · 2cb1342
1 parent c53c26a
commit 2cb1342
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/cmd/staterecovery/staterecovery.go b/cmd/staterecovery/staterecovery.go
@@ -4,7 +4,6 @@ import (
 	"fmt"
 	"time"
 
-	"github.com/ethereum/go-ethereum/common"
 	"github.com/ethereum/go-ethereum/core"
 	"github.com/ethereum/go-ethereum/core/state"
 	"github.com/ethereum/go-ethereum/core/vm"
@@ -36,10 +35,9 @@ func RecreateMissingStates(chainDb ethdb.Database, bc *core.BlockChain, cacheCon
 	if err != nil {
 		return fmt.Errorf("genesis state is missing: %w", err)
 	}
-	_ = database.TrieDB().Reference(previousBlock.Root(), common.Hash{})
-	defer func() {
-		_ = database.TrieDB().Dereference(previousBlock.Root())
-	}()
+	// we don't need to reference states with `trie.Database.Reference` here, because:
+	// * either the state nodes will be read from disk and then cached in cleans cache
+	// * or they will be recreated, saved to disk and then also cached in cleans cache
 	logged := time.Now()
 	recreated := 0
 	for current <= last {
@@ -75,8 +73,6 @@ func RecreateMissingStates(chainDb ethdb.Database, bc *core.BlockChain, cacheCon
 			}
 			recreated++
 		}
-		_ = database.TrieDB().Reference(currentBlock.Root(), common.Hash{})
-		_ = database.TrieDB().Dereference(previousBlock.Root())
 		current++
 		previousBlock = currentBlock
 		previousState = currentState