Merge pull request #2801 from OffchainLabs/overflow_check

[NIT-2944] Check batchProcessed > 0 to avoid underflow
OffchainLabs · Nov 20, 2024 · 288a285 · 288a285
2 parents 387ac79 + 3b07fcc
commit 288a285
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/arbnode/sync_monitor.go b/arbnode/sync_monitor.go
@@ -146,11 +146,13 @@ func (s *SyncMonitor) FullSyncProgressMap() map[string]interface{} {
 		batchProcessed := s.inboxReader.GetLastReadBatchCount()
 		res["batchProcessed"] = batchProcessed
 
-		processedBatchMsgs, err := s.inboxReader.Tracker().GetBatchMessageCount(batchProcessed - 1)
-		if err != nil {
-			res["batchMetadataError"] = err.Error()
-		} else {
-			res["messageOfProcessedBatch"] = processedBatchMsgs
+		if batchProcessed > 0 {
+			processedBatchMsgs, err := s.inboxReader.Tracker().GetBatchMessageCount(batchProcessed - 1)
+			if err != nil {
+				res["batchMetadataError"] = err.Error()
+			} else {
+				res["messageOfProcessedBatch"] = processedBatchMsgs
+			}
 		}
 
 		l1reader := s.inboxReader.l1Reader