code refactor

arbstate/daprovider/util.go

@@ -43,6 +43,8 @@ type BlobReader interface {
 	Initialize(ctx context.Context) error
 }
 
+// PreimageRecorder is used to add (key,value) pair to the map accessed by key = ty of a bigger map, preimages.
+// If ty doesn't exist as a key in the preimages map, then it is intialized to map[common.Hash][]byte and then (key,value) pair is added
 type PreimageRecorder func(key common.Hash, value []byte, ty arbutil.PreimageType)
 
 // RecordPreimagesTo takes in preimages map and returns a function that can be used

arbstate/daprovider/writer.go

@@ -33,7 +33,7 @@ type writerForDAS struct {
 }
 
 func (d *writerForDAS) Store(ctx context.Context, message []byte, timeout uint64, sig []byte, disableFallbackStoreDataOnChain bool) ([]byte, error) {
-	cert, err := d.dasWriter.Store(ctx, message, timeout, []byte{}) // b.daWriter will append signature if enabled
+	cert, err := d.dasWriter.Store(ctx, message, timeout, []byte{})
 	if errors.Is(err, ErrBatchToDasFailed) {
 		if disableFallbackStoreDataOnChain {
 			return nil, errors.New("unable to batch to DAS and fallback storing data on chain is disabled")

staker/stateless_block_validator.go

@@ -261,8 +261,8 @@ func (v *StatelessBlockValidator) ValidationEntryRecord(ctx context.Context, e *
 		foundDA := false
 		for _, dapReader := range v.dapReaders {
 			if dapReader != nil && dapReader.IsValidHeaderByte(batch.Data[40]) {
-				recorder := daprovider.RecordPreimagesTo(e.Preimages)
-				_, err := dapReader.RecoverPayloadFromBatch(ctx, batch.Number, batch.BlockHash, batch.Data, recorder, true)
+				preimageRecorder := daprovider.RecordPreimagesTo(e.Preimages)
+				_, err := dapReader.RecoverPayloadFromBatch(ctx, batch.Number, batch.BlockHash, batch.Data, preimageRecorder, true)
 				if err != nil {
 					// Matches the way keyset validation was done inside DAS readers i.e logging the error
 					//  But other daproviders might just want to return the error