Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test startup for more variations of command line args #78

Merged
merged 11 commits into from
Sep 18, 2024
Merged

Conversation

yahgwai
Copy link
Contributor

@yahgwai yahgwai commented Sep 2, 2024

No description provided.

@yahgwai yahgwai changed the title Test commit Test startup for more variations of command line args Sep 2, 2024
@yahgwai yahgwai requested review from gzeoneth and tsahee September 2, 2024 17:08
Copy link
Contributor

@gvladika gvladika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there are some more L3 related flags which are used in CIs across different repos and have caused previousy crashes/issues: --l3-fee-token --l3-token-bridge --l3-fee-token-decimals 6. We don't need to test every possible combo with these, but I think at least one run with all of them would be useful have

@yahgwai yahgwai requested a review from gvladika September 18, 2024 11:42
Copy link
Contributor

@gvladika gvladika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tsahee tsahee merged commit 43861b0 into release Sep 18, 2024
12 checks passed
@tsahee tsahee deleted the ci-startup branch September 18, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants