Deploy CacheManager to L2 and L3 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzeoneth
reviewed
Jun 18, 2024
| @@ -378,7 +378,7 @@ function writeL3ChainConfig(argv: any) { | |||
| "AllowDebugPrecompiles": true, | |||
| "DataAvailabilityCommittee": false, | |||
| "InitialArbOSVersion": 30, | |||
| "InitialChainOwner": "0x0000000000000000000000000000000000000000", | |||
| "InitialChainOwner": argv.l2owner, | |||
There was a problem hiding this comment.
wonder if this changing the rollup creation salt and thus address would cause issue downstream
There was a problem hiding this comment.
not 100% sure, but I think in most places/repos we moved away from hard-coded addresses and instead get them by parsing files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy CacheManager and enable it on L2 and L3 by calling nitro-contracts' action
Set initial chain owners on L2 and L3 to be l2owner and l3owner accounts
Resolves BLK-170