support cross-compilation of stylus programs #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsahee
previously approved these changes
Aug 27, 2024
ethdb/database.go
Outdated
| @@ -194,4 +199,5 @@ type Database interface { | |||
| Snapshotter | |||
| io.Closer | |||
| WasmDataBaseRetriever | |||
| WasmTargetsRetriever | |||
There was a problem hiding this comment.
can we merge WasmTargetsRetriever and WasmDataBaseRetriever?
In a future PR I hope to remove all of them.
There was a problem hiding this comment.
I moved the WasmTargets() method to WasmDataBaseRetriever.
Would it make sense to instead of having wasmdb and wasmTag in cachingDB to have:
func (db *cachingDB) WasmStore() ethdb.KeyValueStore {
wasmdb, _ := wasmDatabsaseRetriever.WasmDatabase()
return wasmdb
}
func (db *cachingDB) WasmCacheTag() uint32 {
_, wasmTag := wasmDatabsaseRetriever.WasmDatabase()
return wasmTag
}
?
tsahee
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves NIT-2632