Integrate CaptureArbitrumStorageGet/Set into the prestate tracer #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et-prestatetracer
ganeshvanahalli
requested review from
diegoximenes,
amsanghi,
magicxyyz and
gligneul
diegoximenes
requested changes
Aug 27, 2024
diegoximenes
previously approved these changes
Sep 5, 2024
…]et initialization for prestateTracer
diegoximenes
requested changes
Nov 7, 2024
Co-authored-by: Diego Ximenes Mendes <[email protected]>
diegoximenes
previously approved these changes
Nov 19, 2024
tsahee
requested changes
Dec 13, 2024
core/tracing/hooks.go
Outdated
| CaptureArbitrumStorageGetHook = func(key common.Hash, depth int, before bool) | ||
| CaptureArbitrumStorageSetHook = func(key, value common.Hash, depth int, before bool) | ||
| CaptureArbitrumStorageGetHook = func(addr common.Address, key, mappedKey common.Hash, depth int, before bool) | ||
| CaptureArbitrumStorageSetHook = func(addr common.Address, key, mappedKey, value common.Hash, depth int, before bool) |
There was a problem hiding this comment.
addr should always be the arbosStorage address. We can add it here but not really necessary.
We shouldn't need mapped key because that's what "key" should mean. Storage is just key-value pairs and we don't care about the non-mapped key.
eth/tracers/native/prestate.go
Outdated
| @@ -47,10 +47,13 @@ type account struct { | |||
| Nonce uint64 `json:"nonce,omitempty"` | |||
| Storage map[common.Hash]common.Hash `json:"storage,omitempty"` | |||
| empty bool | |||
|
|
|||
| ArbitrumStorage map[common.Hash]common.Hash `json:"arbitrumStorage,omitempty"` | |||
| arbStorageKeyMap map[common.Hash]common.Hash | |||
There was a problem hiding this comment.
Prestate is just about finding all the places in storage that chaged.
We're not trying to add new things there. It already supports writes that happen during EVM by mimicing an SLOAD/SSTORE.
We just want to add the accesses that happened before EVM execution to the same place.
So we shouldn't need new entries. It should all be normal entries in the arbosstorage account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled by OffchainLabs/nitro#2602
Part of NIT-2733