Allow lowering of basefee to 0 if vm runs with NoBaseFee flag and 0 gas price #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsahee
reviewed
Jun 14, 2024
Tristan-Wilson
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to NIT-2412
Introduce
BaseFeeCopyfield in vm.BlockContext to persist BaseFee value when its lowered to 0 to preserve EVM invariantbasefee < feecapin cases vm is run with NoBaseFee flag and 0 gas price.This enables nitro to use persisted basefee value in TxProcessor hooks and ArbGasInfo precompile during eth_call, eth_estimateGas, etc
Pulled in by:-OffchainLabs/nitro#2358