Add Precompile for secp256r1 conditionally based on ArbOS version #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ereum into secp256r1-precompile
…ereum into secp256r1-precompile
PlasmaPower
reviewed
Apr 18, 2024
core/vm/contracts.go
Outdated
| return PrecompiledAddressesArbitrum | ||
| var ret []common.Address | ||
| if rules.ArbOSVersion >= 30 { | ||
| ret = append(ret, PrecompiledAddressesP256Verify...) |
There was a problem hiding this comment.
- This is called every tx, so I think we should consider caching this as PrecompiledAddressesArbOS30 or such
- We also need to update the EVM's
precompilemethod in core/vm/evm.go
There was a problem hiding this comment.
Good catch, updated evm's precompile as well and introduced PrecompiledAddresses[/Contracts]ArbOS30 that is populated in geth hook (OffchainLabs/nitro#2239).
magicxyyz
requested changes
Apr 27, 2024
core/vm/contracts.go
Outdated
| PrecompiledAddressesIstanbul []common.Address | ||
| PrecompiledAddressesByzantium []common.Address | ||
| PrecompiledAddressesHomestead []common.Address | ||
| PrecompiledAddressesP256Verify []common.Address |
There was a problem hiding this comment.
do we need this? looks like we include those addresses in PrecompiledAddressesArbOS30 instead
There was a problem hiding this comment.
Removed, I think it might've been needed in an older version of how precompile activation worked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes forked from: https://github.com/ulerdogan/go-ethereum/pull/1/files