Fix ArbitrumLegacyTxData decoding #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tristan-Wilson
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
LGTM
I checked how we had missed this. In this commit 8303a8b upstream switched over from rlp.DecodeBytes on all the tx types to using their .decode methods, and we didn't have one for ArbitrumLegacyTxType 8303a8b#diff-8fb609018eccff10931645347515b8ecc194992cc4ef9e84ebdea87682dd50c3R218)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArbitrumLegacyTxData is RLP encoded and decoded, but the fallback to LegacyTxData's implementation of encode and decode was causing panics: OffchainLabs/nitro#2131